Changeset 4456 for trunk/base


Ignore:
Timestamp:
Jan 5, 2004, 3:07:46 AM (20 years ago)
Author:
jkh
Message:

Back out previous "fix" to option_proc - it only "worked" by masking the symptoms entirely. I'll have to
do more checking into why the option gets occasionally set to "uplist" and blows up the trace function.

P.S. This code is very hard to understand. I don't even know why it globalizes this variable, but it's
obviously essential to its function to do so. Just reading the function itself is not enlightening at
all given that this code is essentially write-only. Perhaps PERL should have been chosen as the implementation
language instead - at least then it would have been deliberate. :)

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/base/src/port1.0/portutil.tcl

    r4454 r4456  
    168168
    169169proc option_proc {option args} {
    170     global option_procs
     170    global option_procs $option
    171171    eval "lappend option_procs($option) $args"
    172172    # Add a read trace to the variable, as the option procedures have no access to reads
Note: See TracChangeset for help on using the changeset viewer.